Skip to content

Add nans_to_nulls to Frame #20314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 21, 2025
Merged

Add nans_to_nulls to Frame #20314

merged 8 commits into from
Oct 21, 2025

Conversation

@galipremsagar
Copy link
Contributor

Description

Closes: #20296

This PR adds nans_to_nulls to Frame such that we don't error for Index & MultiIndex cases.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Oct 20, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner October 20, 2025 16:11
@galipremsagar galipremsagar added the bug Something isn't working label Oct 20, 2025
@galipremsagar galipremsagar requested a review from vyasr October 20, 2025 16:11
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. labels Oct 20, 2025
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Oct 20, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 20, 2025
mroeschke
mroeschke reviewed Oct 20, 2025
View reviewed changes
@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Oct 21, 2025
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 21, 2025
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8f37a36 into rapidsai:main Oct 21, 2025
132 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 21, 2025
@mroeschke mroeschke mentioned this pull request Oct 21, 2025
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Oct 22, 2025
@mroeschke
Avoid Column materialization in RangeIndex.nans_to_nulls (#20331)
8cdbe0b 
Follow up to #20314

Realized after review we can avoid materializing the `range` to a `Column`

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #20331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] MultiIndex doesn't have nans_to_nulls defined

2 participants

@galipremsagar @mroeschke